Handle the case if json tag was not overwritten #23

borosr · 2023-01-29T15:44:48Z

If the json tag was not present in the go_struct_tags option, the lib would use the default json tag, generated by protobuf.
#22

PumpkinSeed

Actually what you should do, you have to get the o.goStructTags, and if there is a tag from the override than 1. override the value if it exists in the o.goStructTags, 2. add it if it's not exists. The current solution somehow overcomplicate the problme. Correct me if I'm wrong and you are doing this.

borosr · 2023-02-19T21:36:28Z

Basically, my implementation is doing the same in the getAdditionalTags function, where the logic is:

Reading the goStructTags attached to the field - if empty, return with the default json tag
Parsing the passed goStructTags, but skipping those which are generated for gRPC
At this point, we have an array full of non-existing and/or the overwritten json tag in it
Checking if the parsed array is containing json tag, if not, then add the default json tag to the parsed array

handle the case if json was not overwritten

2ed2f22

borosr requested a review from PumpkinSeed January 29, 2023 15:44

borosr self-assigned this Jan 29, 2023

PumpkinSeed requested changes Jan 31, 2023

View reviewed changes

borosr added 2 commits February 5, 2023 20:05

add protobuf_oneof to tag build tag filter, to skip it from override

e1a6f80

simplify code

17796ea

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle the case if json tag was not overwritten #23

Handle the case if json tag was not overwritten #23

borosr commented Jan 29, 2023

PumpkinSeed left a comment

borosr commented Feb 19, 2023

Handle the case if json tag was not overwritten #23

Are you sure you want to change the base?

Handle the case if json tag was not overwritten #23

Conversation

borosr commented Jan 29, 2023

PumpkinSeed left a comment

Choose a reason for hiding this comment

borosr commented Feb 19, 2023